Skip to content

[addon-operator] add nelm debug#782

Merged
ldmonster merged 2 commits into
release-1.21from
chore/1-21-add-nelm-debug
Jun 23, 2026
Merged

[addon-operator] add nelm debug#782
ldmonster merged 2 commits into
release-1.21from
chore/1-21-add-nelm-debug

Conversation

@ldmonster

@ldmonster ldmonster commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Overview

What this PR does / why we need it

ldmonster and others added 2 commits June 23, 2026 12:11
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
@ldmonster ldmonster self-assigned this Jun 23, 2026
@ldmonster ldmonster added the dependencies Pull requests that update a dependency file label Jun 23, 2026
@ldmonster ldmonster merged commit c0d2e85 into release-1.21 Jun 23, 2026
7 of 9 checks passed
@ldmonster ldmonster deleted the chore/1-21-add-nelm-debug branch June 23, 2026 10:08
Comment thread pkg/helm/nelm/nelm.go
Comment on lines +402 to +407
file, err := os.ReadFile(installGraphPath)
if err != nil {
logger.Error("failed to read install graph file", slog.String("path", installGraphPath), log.Err(err))
} else {
logger.Debug("nelm graph file", slog.Any("graph", string(file)))
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be wrapped in if os.Getenv(nelmDependencyGraphEnabled) == "true"

Comment thread pkg/helm/nelm/nelm.go
Comment on lines +509 to +514
file, err := os.ReadFile(installGraphPath)
if err != nil {
c.logger.Error("failed to read install graph file", slog.String("path", installGraphPath), log.Err(err))
} else {
c.logger.Debug("nelm graph file", slog.Any("graph", string(file)))
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be wrapped in if os.Getenv(nelmDependencyGraphEnabled) == "true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants